core: frontend: vehiclesetup: PwmSetup: Lighten vehicle background - #4157
core: frontend: vehiclesetup: PwmSetup: Lighten vehicle background#4157patrickelectric wants to merge 4 commits into
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Automated PR Review0. Summary
Adds No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
|
I'm unsure whether this tackles the issue: I can barely notice the difference in light mode, and it looks weird in dark mode: 
Maybe it should be less transparent, instead? Or having a transparency slider and/or a background color luminosity if we can't find good values that work for everybody? |
grey lighten-3 is almost invisible in light mode and a bright rectangle in dark mode. Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
|
@joaoantoniocardoso dropped the grey card, model is opaque now. Check now ? |
I think that solves the problem of the vehicle visibility by creating another problem: now, when hovering over the motors list, we can't visually locate which motor is which in the frame. |
Hovering a motor in the list needs the ghosted model to show which one is selected. Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…el alpha 0.05 made the vehicle disappear in dark mode. Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
|
@joaoantoniocardoso restored transparency for hover and raised the ghost alpha. Check now ? |
|
It does look better, but it is still difficult to identify the motors, especially in dark mode. Maybe we can tint the motor a color with good contrast against a light or dark background, say, red? |
|
Ok, will take a look |
2 participants
The vehicle is almost invisible on the pwm outputs tab in dark mode.
Fix #1674